Skip to content

fix: jq-web -> jq-wasm, includes jq verison 1.8.1#2223

Merged
GCHQDeveloper581 merged 3 commits intogchq:masterfrom
W-Floyd:jq-fix
Mar 6, 2026
Merged

fix: jq-web -> jq-wasm, includes jq verison 1.8.1#2223
GCHQDeveloper581 merged 3 commits intogchq:masterfrom
W-Floyd:jq-fix

Conversation

@W-Floyd
Copy link
Contributor

@W-Floyd W-Floyd commented Mar 5, 2026 •
edited
Loading

Resolves #2209. Switches from https://github.com/fiatjaf/jq-web to https://github.com/owenthereal/jq-wasm, which seems to be updated more frequently.

@GCHQDeveloper581
Copy link
Contributor

GCHQDeveloper581 commented Mar 6, 2026

Yours is otherwise the better solution, so I've pulled in a couple of tests from my attempt to fix the same issue.

GCHQDeveloper581
GCHQDeveloper581 approved these changes Mar 6, 2026
View reviewed changes
Copy link
Contributor

@GCHQDeveloper581 GCHQDeveloper581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Many thanks for your contribution.

@GCHQDeveloper581 GCHQDeveloper581 merged commit 0c6454e into gchq:master Mar 6, 2026
2 checks passed
This was referenced Mar 6, 2026
Merged
Open
@W-Floyd W-Floyd mentioned this pull request Mar 9, 2026
Closed
@W-Floyd
Copy link
Contributor Author

W-Floyd commented Mar 9, 2026

@GCHQDeveloper581 looks like this has a performance penalty - thoughts on reverting to jq-web 1.5.1 until I/we figure out a better solution?

@GCHQDeveloper581
Copy link
Contributor

GCHQDeveloper581 commented Mar 11, 2026

At present reverting to jq-web 0.5.1 looks like being the best interim solution.

(The original update to 0.6.2 wasn't driven by anything beyond a desire to get dependencies as up-to-date as possible)

I note that the README for jq-web (https://www.npmjs.com/package/jq-web) does talk about some things required to get it going with webpack - I haven't (yet) explored whether these are already applied in the CyberChef codebase.

GCHQDeveloper581 added a commit to GCHQDeveloper581/CyberChef that referenced this pull request Mar 13, 2026
@GCHQDeveloper581
Revert "fix: jq-web -> jq-wasm, includes jq version 1.8.1 (gc…
f4ca59d 
…hq#2223)"

This reverts commit 0c6454e.
GCHQDeveloper581 added a commit that referenced this pull request Mar 19, 2026
@GCHQDeveloper581
Fix Jq issue (#2210)
d9dacf6 
* Revert "fix: jq-web -> jq-wasm, includes jq version 1.8.1 (#2223)"
  This reverts commit 0c6454e.
  (but leave new tests intact)
* Return jq-web to 0.5.1
@GCHQDeveloper581 GCHQDeveloper581 mentioned this pull request Mar 21, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GCHQDeveloper581 GCHQDeveloper581 GCHQDeveloper581 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug report: jq operation broken in latest update

2 participants

@W-Floyd @GCHQDeveloper581