Skip to content

feat: add Raw option for Jq operation#2237

Merged
GCHQDeveloper581 merged 2 commits intogchq:masterfrom
rtpt-romankarwacik:jq_raw
Mar 20, 2026
Merged

feat: add Raw option for Jq operation#2237
GCHQDeveloper581 merged 2 commits intogchq:masterfrom
rtpt-romankarwacik:jq_raw

Conversation

@rtpt-romankarwacik
Copy link
Contributor

This is useful when data needs to be processed afterwards, for example strings, without needing to strip or unescape afterwards.

@CLAassistant
Copy link

CLAassistant commented Mar 11, 2026

CLA assistant check
All committers have signed the CLA.

@GCHQDeveloper581
Copy link
Contributor

GCHQDeveloper581 commented Mar 11, 2026

Hi,

I'm going to put this one on hold for a little bit, until we resolve the issues in #2232 / #2233 as I don't want to muddy the waters with another change to the same part of the codebase.

@GCHQDeveloper581 GCHQDeveloper581 mentioned this pull request Mar 13, 2026
@GCHQDeveloper581
Copy link
Contributor

I'm going to put this one on hold for a little bit, until we resolve the issues in #2232 / #2233 as I don't want to muddy the waters with another change to the same part of the codebase.

Unlocking this one again - however I note there are currently merge conflicts, possibly because jq library has been changed (back).

@rtpt-romankarwacik
Copy link
Contributor Author

Unlocking this one again - however I note there are currently merge conflicts, possibly because jq library has been changed (back).

I've changed the commit to work with the new master.

Copy link
Contributor

@GCHQDeveloper581 GCHQDeveloper581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you add some tests.

It would be good to see tests for "raw" and "non raw" output on input where this makes a material difference.

Also, please address linting issue found in checks.

@rtpt-romankarwacik
Copy link
Contributor Author

I added a test and fixed the linting.

Copy link
Contributor

@GCHQDeveloper581 GCHQDeveloper581 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for your contribution.

@GCHQDeveloper581 GCHQDeveloper581 merged commit 290f824 into gchq:master Mar 20, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants