fix(A1Z26): return empty string instead of empty array for empty input#2257
Merged
GCHQDeveloper581 merged 2 commits intogchq:masterfrom Mar 19, 2026
Merged
Conversation
The A1Z26 Cipher Decode operation declares outputType as 'string' but returned an empty array for empty input, violating its type contract. Fixes gchq#2248
GCHQDeveloper581
requested changes
Mar 18, 2026
Contributor
GCHQDeveloper581
left a comment
There was a problem hiding this comment.
Please could you add a test that would fail without this change and pass with it.
Contributor
Author
|
Added tests in 06cc1b4:
Test file: |
GCHQDeveloper581
approved these changes
Mar 19, 2026
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Changed the early return for empty input in A1Z26 Cipher Decode from
[]to"".Why
The operation declares
this.outputType = "string", but the empty input check on line 80 returns an empty array:This causes a type mismatch that can break downstream operations expecting a string.
Changes
File:
src/core/operations/A1Z26CipherDecode.mjsif (input.length === 0) { - return []; + return ""; }Fixes #2248