Support Cargo.toml with profile overrides (by using newer version of cargo)#94
Closed
evan-dickinson wants to merge 2 commits intogeiger-rs:masterfrom
Closed
Support Cargo.toml with profile overrides (by using newer version of cargo)#94evan-dickinson wants to merge 2 commits intogeiger-rs:masterfrom
evan-dickinson wants to merge 2 commits intogeiger-rs:masterfrom
Conversation
Author
|
I'm not sure why the CI tests failed. I did |
Contributor
|
Thanks for the PR. It seems like the master branch is failing the tests as well on Azure now. Will look into it later this week. |
Contributor
|
The new test snapshot files seems to have a different naming than the existing ones... |
Contributor
|
Let's roll with the new naming of the test snapshots. Feel free to delete the old snapshots and commit new ones if they look correct. |
Contributor
|
Superseded by #98. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo version 1.41 stabilized profile overrides. But
cargo-geigerstill considered the feature unstable. Running geiger on a crate that uses profile overrides was failing with this error:To fix the problem, I incremented the version of
cargoto0.42.0. And I also rancargo updateto update other dependencies, too.