games-emulation/emulationstation-de: new package, add 3.4.0#432
games-emulation/emulationstation-de: new package, add 3.4.0#432mvidaldp wants to merge 2 commits intogentoo:masterfrom
Conversation
mvidaldp
changed the title
mvidaldp
changed the title
| -DAPPLICATION_UPDATER="$(usex auto-updater ON OFF)" | ||
| -DDEINIT_ON_LAUNCH="$(usex deinit ON OFF)" | ||
| -DVIDEO_HW_DECODING="$(usex video-hw ON OFF)" | ||
| -DASAN="$(usex asan ON OFF)" |
There was a problem hiding this comment.
Address sanitizing is probably something useful for upstream developers but not so much for users. To simplify the ebuild I would remove the asan and profiling USE
|
|
||
| local mycmakeargs=( | ||
| -DCMAKE_BUILD_TYPE="${buildtype}" | ||
| -DAPPLICATION_UPDATER="$(usex auto-updater ON OFF)" |
There was a problem hiding this comment.
Most probably this should be always disabled
There was a problem hiding this comment.
Hi! Thanks for the review — I’ve applied your suggestions and updated the ebuild accordingly.
I understand that for new packages you generally don't merge GitHub PRs, and that I should follow the official GURU contributor onboarding instead. I’ll create a Gentoo Bugzilla account (using the same email as in metadata.xml) and follow the “Information for Contributors” steps to get set up for the GURU workflow / dev branch.
Once that’s done, I'll push my packages via the proper route and close/supersede the previous PR. Thanks again for your patience — first time contributing to GURU.
… and USE Add reviewer suggestions into emulationstation-de ebuild for keywords and USE: - Add copyright - Remove asan and profiling uses - Set autoupdater to off
2 participants
No description provided.