-
Notifications
You must be signed in to change notification settings - Fork 109
Open
Labels
Description
basic.mk is my go-to starting point for Go projects, thanks!
I noticed that a CI job of mine was missing golint, but make all was succeeding. The golint | tee approach was hiding the error return code.
Adding .SHELLFLAGS = -o pipefail -c fixed it for me (i.e. the build now correctly fails if golint is missing).
I see basic.mk has moved on a bit from the version I'm working from, I don't know if the greps in the pipes might mean this approach isn't viable any more?
Just raising this issue in case it's helpful - this isn't an issue with the weather tool, but I couldn't see a 'home' repo for basic.mk. Please do close it if this is the wrong project or this isn't a problem in your use case!
Reactions are currently unavailable