Convert to source generation for logging#356
Merged
geofflamrock merged 2 commits intomainfrom Sep 3, 2025
Merged
Conversation
geofflamrock
force-pushed
the
log-source-generators
branch
3 times, most recently
from
c36b51e to
d242e34
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR converts the codebase from traditional logging calls to source generation for improved performance and better typing. It also removes color formatting from branch and stack names in logging messages to reduce visual distraction, while preserving colors for direct console output.
Key changes:
- Replace
Logger.LogXxx()calls with source-generated logging methods - Add
[LoggerMessage]attributes for compile-time logging optimization - Remove
.Branch(),.Stack(), and.Example()extension methods from logging messages
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| OutputStyleExtensionMethods.cs | Removes unused Example() extension method |
| LoggerExtensionMethods.cs | Adds source-generated logging methods for common operations |
| Command.cs | Converts error logging to source generation and adds internal logger extensions |
| ProcessHelpers.cs | Converts trace logging to source generation |
| GitClient.cs | Converts debug logging to source generation |
| Multiple command files | Replace traditional logging with source-generated methods and remove color formatting |
| [LoggerMessage(Level = LogLevel.Information, Message = "Rebasing stack {Stack} for branch line: {SourceBranch} --> {BranchLine}")] | ||
| public static partial void RebasingStackForBranchLine(this ILogger logger, string stack, string sourceBranch, string branchLine); | ||
|
|
||
| [LoggerMessage(Level = LogLevel.Debug, Message = "No active branches found for branch line.")] |
There was a problem hiding this comment.
The log level should be LogLevel.Warning to match the original code at line 257 which used logger.LogWarning.
Suggested change
| [LoggerMessage(Level = LogLevel.Debug, Message = "No active branches found for branch line.")] | |
| [LoggerMessage(Level = LogLevel.Warning, Message = "No active branches found for branch line.")] |
|
|
||
| internal static partial class LoggerExtensionMethods | ||
| { | ||
| [LoggerMessage(Level = LogLevel.Trace, Message = "Adding branch {Branch} to stack {Stack}.")] |
There was a problem hiding this comment.
The log level should be LogLevel.Information to match the original code at line 102 which used logger.LogInformation.
Suggested change
| [LoggerMessage(Level = LogLevel.Trace, Message = "Adding branch {Branch} to stack {Stack}.")] | |
| [LoggerMessage(Level = LogLevel.Information, Message = "Adding branch {Branch} to stack {Stack}.")] |
Comment on lines
+125
to
+126
| [LoggerMessage(Level = LogLevel.Information, Message = "Branch {Branch} added to stack {Stack}.")] | ||
| public static partial void BranchAdded(this ILogger logger, string branch, string stack); |
There was a problem hiding this comment.
The original message at line 116 was just 'Branch added' without parameters. The message should be 'Branch added.' to match the original behavior.
geofflamrock
force-pushed
the
log-source-generators
branch
from
d242e34 to
7a4d351
Compare
geofflamrock
force-pushed
the
log-source-generators
branch
from
4f604f4 to
9a80cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to use source generation for logging to improve performance and consistency of messages. Some slight changes to log levels of some messages which didn't seem right.