Add feature to configure building with TIFF support.#58
Conversation
|
I'm fine with it, but I think the network / grid download functionality requires libtiff – if we can't build with tiff support on M1, that's the fundamental problem. |
|
(Also, I'm in a writing hole until mid-next week, so I probably won't be able to do much other than talk about potential fixes) |
michaelkirk
left a comment
There was a problem hiding this comment.
if we can't build with tiff support on M1, that's the fundamental problem.
I think you're right about the fundamental problem.
I think it's still an improvement to make tiff support optional (and probably contingent on the network feature). That potentially helps anyone not using the network feature and gives some way of building on M1.
| bundled_proj = [ "proj-sys/bundled_proj" ] | ||
| tiff = [ "proj-sys/tiff" ] | ||
| pkg_config = [ "proj-sys/pkg_config" ] | ||
| network = ["reqwest"] |
There was a problem hiding this comment.
| network = ["reqwest"] | |
| network = ["reqwest", "tiff"] |
Since the network grid requires tiff, maybe like this?
You're absolutely correct. |
michaelkirk
left a comment
There was a problem hiding this comment.
Other than my one suggestion, LGTM!
306962b to
0a3ef92
Compare
|
bors r=michaelkirk |
|
Build succeeded: |
|
\o/ |
Thoughts? Would be a breaking change since it defaults to not building with TIFF support, and it used to