Skip to content

Add feature to configure building with TIFF support.#58

Merged
bors[bot] merged 3 commits into
masterfrom
frewsxcv-tiff
Jan 15, 2021
Merged

Add feature to configure building with TIFF support.#58
bors[bot] merged 3 commits into
masterfrom
frewsxcv-tiff

Conversation

@frewsxcv
Copy link
Copy Markdown
Member

Thoughts? Would be a breaking change since it defaults to not building with TIFF support, and it used to

@urschrei
Copy link
Copy Markdown
Member

I'm fine with it, but I think the network / grid download functionality requires libtiff – if we can't build with tiff support on M1, that's the fundamental problem.

@urschrei
Copy link
Copy Markdown
Member

(Also, I'm in a writing hole until mid-next week, so I probably won't be able to do much other than talk about potential fixes)

Copy link
Copy Markdown
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can't build with tiff support on M1, that's the fundamental problem.

I think you're right about the fundamental problem.

I think it's still an improvement to make tiff support optional (and probably contingent on the network feature). That potentially helps anyone not using the network feature and gives some way of building on M1.

Comment thread Cargo.toml Outdated
bundled_proj = [ "proj-sys/bundled_proj" ]
tiff = [ "proj-sys/tiff" ]
pkg_config = [ "proj-sys/pkg_config" ]
network = ["reqwest"]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
network = ["reqwest"]
network = ["reqwest", "tiff"]

Since the network grid requires tiff, maybe like this?

@urschrei
Copy link
Copy Markdown
Member

I think it's still an improvement to make tiff support optional (and probably contingent on the network feature). That potentially helps anyone not using the network feature and gives some way of building on M1.

You're absolutely correct.

Copy link
Copy Markdown
Member

@michaelkirk michaelkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one suggestion, LGTM!

@frewsxcv
Copy link
Copy Markdown
Member Author

bors r=michaelkirk

@bors
Copy link
Copy Markdown
Contributor

bors Bot commented Jan 15, 2021

Build succeeded:

@bors bors Bot merged commit 0c5bc76 into master Jan 15, 2021
@urschrei
Copy link
Copy Markdown
Member

\o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants