Fix #10448 Map plugin should not initizialize invalid maps #10449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tdipisa
added
the
BackportNeeded
offtherailz
approved these changes
Oct 14, 2024
offtherailz
approved these changes
Oct 21, 2024
Member
offtherailz
left a comment
offtherailz
left a comment
There was a problem hiding this comment.
This fixes the issue. So it's good to go.
A more rational approach may have a loading flag that prevents to render with invalid props, and check invalid maps only to display errors.
But this may require a refactor, not object of this fix.
Member
|
@ElenaGallo, could you please test this on DEV ? Thank you |
Contributor
|
Test passed, @allyoucanmap please backport to 2024.02.xx. Thanks |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Nov 5, 2024
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Nov 5, 2024
rmelarab-ngs
pushed a commit
to ngsllc/MapStore2
that referenced
this pull request
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes following fixes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10448
What is the new behavior?
Map plugin components mount only when a valid configuration is provided
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information