Dashboards - no longer shows counter widgets #10708#10714
Merged
offtherailz merged 2 commits intogeosolutions-it:masterfrom Dec 4, 2024
Merged
Dashboards - no longer shows counter widgets #10708#10714offtherailz merged 2 commits intogeosolutions-it:masterfrom
offtherailz merged 2 commits intogeosolutions-it:masterfrom
Conversation
1 task
tdipisa
added
Internal
BackportNeeded
offtherailz
approved these changes
Dec 4, 2024
Member
|
@ElenaGallo, could you please test this on DEV ? Thank you |
Contributor
|
Test passed, @rowheat02 please backport to 2024.02.xx. Thanks |
rowheat02
added a commit
to rowheat02/MapStore2
that referenced
this pull request
Dec 5, 2024
…geosolutions-it#10708 (geosolutions-it#10714) * fix: allow api call for viewport null and widgets not synced with map widget * fix: check mapSync dependencyMap for standard map also
tdipisa
pushed a commit
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Last time in a174c99
Double API fetch was avoided by checking the viewPort and mapSync.
But Widgets can be synced to table widget also.
So now initial API fetch is avoided when viewport is null and widget is synced to mapWidget.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
#10708
What is the current behavior?
#10708
Widget synced with table was invisible
What is the new behavior?
Widgets synced with the table are visible. Double API call avoided for the widgets synced to map.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information