Skip to content

Max zoom level configuration from localConfig for Coordinate Search #11154#11159

Merged
MV88 merged 4 commits intogeosolutions-it:masterfrom
rowheat02:coordinateSearchmaxzoom
Jun 5, 2025
Merged

Max zoom level configuration from localConfig for Coordinate Search #11154#11159
MV88 merged 4 commits intogeosolutions-it:masterfrom
rowheat02:coordinateSearchmaxzoom

Conversation

@rowheat02
Copy link
Contributor

Description

Max zoom level while performing the Coordinate search can be configured from localConfig
image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

fixes #11154

What is the current behavior?

#11154

What is the new behavior?
Max zoom level for Coordinate Search can be configured from localConfig.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2025.01.01 milestone May 30, 2025
@rowheat02 rowheat02 self-assigned this May 30, 2025
@rowheat02 rowheat02 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels May 30, 2025
@rowheat02 rowheat02 changed the title Coordinate searchmaxzoom Max zoom level configuration from localConfig for Coordinate Search #11154 May 30, 2025
@tdipisa tdipisa requested review from MV88 and dsuren1 and removed request for dsuren1 May 30, 2025 12:12
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • do not edit localConfig if there are default values is better use them
  • also check other inline comments

@rowheat02 rowheat02 requested a review from MV88 June 5, 2025 12:18
@MV88
Copy link
Contributor

MV88 commented Jun 5, 2025

fix the test and we are good

@MV88 MV88 merged commit 2c08158 into geosolutions-it:master Jun 5, 2025
5 checks passed
@MV88
Copy link
Contributor

MV88 commented Jun 5, 2025

@ElenaGallo please test it in DEV

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jun 9, 2025
…eosolutions-it#11154 (geosolutions-it#11159)

* feat: max zoom level for Coordinate search configurable from localConfig

* fix: delete copied file

* fix: requested changes

* change test text
rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jun 10, 2025
…eosolutions-it#11154 (geosolutions-it#11159)

* feat: max zoom level for Coordinate search configurable from localConfig

* fix: delete copied file

* fix: requested changes

* change test text
@ElenaGallo
Copy link
Contributor

Test passed, @rowheat02 please backport to 2025.01.xx. Thanks

tdipisa pushed a commit that referenced this pull request Jun 18, 2025
…11154 (#11159) (#11181)

* feat: max zoom level for Coordinate search configurable from localConfig

* fix: delete copied file

* fix: requested changes

* change test text
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Max zoom level configuration from localConfig for Coordinate Search

4 participants