Skip to content

Edit Map Details as USER role will fail saving if resource is within group #11242 #11278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
offtherailz merged 2 commits into from
Jul 8, 2025
Merged

Edit Map Details as USER role will fail saving if resource is within group #11242 #11278

offtherailz merged 2 commits into from
Jul 8, 2025

Conversation

@rowheat02
Copy link
Contributor

@rowheat02 rowheat02 commented Jul 3, 2025 •
edited
Loading

Description

Permission API is now called separately, avoiding parallel execution alongside other related resource APIs

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • [] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

fixes #11242

What is the current behavior?

#11242

What is the new behavior?

Now it will not fail when User role user tries to save resources after fetching permissions.
Parallel api call with permission is avoided in this PR.

Screen.Recording.2025-07-03.at.17.58.47.mov

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@rowheat02 rowheat02 added this to the 2025.01.01 milestone Jul 3, 2025
@rowheat02 rowheat02 marked this pull request as ready for review July 3, 2025 12:15
@rowheat02 rowheat02 self-assigned this Jul 3, 2025
@tdipisa tdipisa requested a review from allyoucanmap July 3, 2025 12:57
@offtherailz offtherailz merged commit ecddecb into geosolutions-it:master Jul 8, 2025
6 checks passed
@offtherailz
Copy link
Member

offtherailz commented Jul 8, 2025 •
edited
Loading

@ElenaGallo, could you please test this on DEV ? Thank you

after test @rowheat02 please backport

@offtherailz offtherailz added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 8, 2025
@ElenaGallo
Copy link
Contributor

ElenaGallo commented Jul 9, 2025

Test passed, @rowheat02 please backport to 2025.01.xx. Thanks

rowheat02 added a commit to rowheat02/MapStore2 that referenced this pull request Jul 9, 2025
@rowheat02
Edit Map Details as USER role will fail saving if resource is within …
3bfb050 
…group geosolutions-it#11242 (geosolutions-it#11278)

* fix: update all permission api calls to be called independently

* fix: add unit test
@rowheat02 rowheat02 mentioned this pull request Jul 9, 2025
Merged
tdipisa pushed a commit that referenced this pull request Jul 9, 2025
@rowheat02
Edit Map Details as USER role will fail saving if resource is within …
e2d6f30 
…group #11242 (#11278) (#11294)

* fix: update all permission api calls to be called independently

* fix: add unit test
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jul 9, 2025
@allyoucanmap allyoucanmap mentioned this pull request Sep 24, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@offtherailz offtherailz offtherailz approved these changes

@allyoucanmap allyoucanmap Awaiting requested review from allyoucanmap

Assignees

@rowheat02 rowheat02

Labels

bug C044-VLAANDEREN-2024-SUPPORT

Projects

None yet

Milestone

2025.01.01

Development

Successfully merging this pull request may close these issues.

Edit Map Details as USER role will fail saving if resource is within group

4 participants

@rowheat02 @offtherailz @ElenaGallo @tdipisa