Fix unload resources at logout#11480
Merged
allyoucanmap merged 2 commits intogeosolutions-it:masterfrom Sep 16, 2025
Merged
Conversation
1 task
stefanocudini
added
the
BackportNeeded
stefanocudini
force-pushed
the
11459-fix-unload-resources-on-logout
branch
3 times, most recently
from
e0b654a to
9e39759
Compare
stefanocudini
force-pushed
the
11459-fix-unload-resources-on-logout
branch
from
9e39759 to
eb35417
Compare
added new epic unloadresources in ResourcesCatalog added unit test for resources epic hide save button in infopanel for no-logged users
stefanocudini
force-pushed
the
11459-fix-unload-resources-on-logout
branch
from
eb35417 to
bc3d1b8
Compare
Contributor
There was a problem hiding this comment.
There are few issues already solved in this commit dfe2022 . I'm including description for future testing:
- if the details panel is open on logout the content will be empty. The proposed solution is to close the panel on logout.
logout-empty-panel.mp4
- the details panel does not update on login (in the video we expect also permissions and details for admin user). The proposed solutions is to apply same workflow as we added for logout to login success process
login-no-permissions.mp4
1 task
allyoucanmap
approved these changes
Sep 16, 2025
Contributor
|
@ElenaGallo please test this fix on dev and let us know if we can backport to 2025.01.xx, thanks |
Contributor
|
Test passed, @stefanocudini please backport to 2025.01.xx. Thanks |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Sep 17, 2025
--------- Co-authored-by: allyoucanmap <stefano.bovio@geosolutionsgroup.com>
allyoucanmap
removed
the
BackportNeeded
allyoucanmap
added a commit
that referenced
this pull request
Sep 17, 2025
Member
Author
@ElenaGallo during my absence, it was backported here: #11491 |
tdipisa
added
the
BackportNeeded
tdipisa
removed
the
BackportNeeded
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue #11459
Define new actions, reducers, epic in the plugin
ResourcesCatalog.around the action LOGOUT, introduce new action UNLOAD_RESOURCES triggered to clear the state section that refers to the selected resource for unlogged users, clear this state sections:
resources.initialSelectedResourceresources.selectedResourceThis new feature fixes some issues related to inconsistency state for non-logged in users.
Includes also a patch that hides the edit/save button in the info panel for non-logged users (this is based on the user's logged condition because the
canEditfield is not enough to hide the button, the resourcecanCopyfield for public resources override the canEdit condition (see details in the linked issues)(previous exposed here: #11459 (comment))
unloadResourcesin ResourcesCatalogDescription
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#11459
What is the new behavior?
Hides the correct items after on logout.
pixes.mp4
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information