allow specifying third-party plugins via custom-build.sh, improve plugins download#169
Open
derhuerst wants to merge 10 commits intogeosolutions-it:masterfrom
Open
allow specifying third-party plugins via custom-build.sh, improve plugins download#169derhuerst wants to merge 10 commits intogeosolutions-it:masterfrom
derhuerst wants to merge 10 commits intogeosolutions-it:masterfrom
Conversation
…orge, delete ZIP file too
derhuerst
force-pushed
the
tweak-plugins-download
branch
from
72a7256 to
1999644
Compare
|
@camuffo @randomorder Any chance this could be reviewed and merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from fixing various bugs in
geoserver-plugin-download.sh, the change incustom-build.shallows me to build a Docker image with third-party (e.g. locally hosted) plugins.There are some commits with a low but non-negligible changes of breaking users' workflows, those are marked with
<type>!in the beginning following the Conventional Commits spec.Also, I changed the Dockefile to expose the GeoServer version as a
org.opencontainers.image.versionlabel on the image.