Skip to content

Add option to specify remote domains for image resizing #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulrobertlloyd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add option to specify remote domains for image resizing #820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/endpoint-image/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ To customise the behaviour of this plug-in, add `@indiekit/endpoint-image` to yo

## Options

| Option | Type | Description |
| :---------- | :--------- | :----------------------------------------------------------------- |
| `cache` | `Function` | [Keyv store](https://github.com/lukechilds/keyv). |
| `me` | `string` | Publication URL. Used as prefix to image paths. |
| `mountPath` | `string` | Path to image resizing endpoint. _Optional_, defaults to `/image`. |
| Option | Type | Description |
| :---------- | :--------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `cache` | `Function` | [Keyv store](https://github.com/lukechilds/keyv). |
| `domains` | `Array` | List of domains to allow remote image resizing for. _Optional_, defaults to the [value provided for `publication.me`.](https://getindiekit.com/configuration/publication#me) |
| `me` | `string` | Publication URL. Used as prefix to image paths. |
| `mountPath` | `string` | Path to image resizing endpoint. _Optional_, defaults to `/image`. |
13 changes: 10 additions & 3 deletions packages/endpoint-image/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,15 @@ import {
createIPXNodeServer,
} from "ipx";

const defaults = { mountPath: "/image" };
const defaults = { domains: [], mountPath: "/image" };
const router = express.Router();

export default class ImageEndpoint {
name = "Image resizing endpoint";

constructor(options = {}) {
this.options = { ...defaults, ...options };
this.domains = this.options.domains;
this.mountPath = this.options.mountPath;
}

Expand All @@ -23,9 +24,15 @@ export default class ImageEndpoint {
}

_routes(indiekitConfig) {
const domains = Array.isArray(this.domains) ? this.domains : [this.domains];

const ipx = createIPX({
storage: ipxFSStorage({ dir: "./public" }),
httpStorage: ipxHttpStorage({ domains: indiekitConfig.publication.me }),
storage: ipxFSStorage({
dir: "./public",
}),
httpStorage: ipxHttpStorage({
domains: [indiekitConfig.publication.me, ...domains],
}),
});

router.use(createIPXNodeServer(ipx));
Expand Down
Loading