fix: ensure name is a string before calling replace in getError#826
Open
rmdes wants to merge 1 commit intogetindiekit:mainfrom
Open
fix: ensure name is a string before calling replace in getError#826rmdes wants to merge 1 commit intogetindiekit:mainfrom
rmdes wants to merge 1 commit intogetindiekit:mainfrom
Conversation
Prevents "name.replace is not a function" error when code passed to IndiekitError is not a string (e.g., when response.statusText is undefined in some edge cases) Co-Authored-By: Claude Opus 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents "name.replace is not a function" error when the code passed to
IndiekitErroris not a string (e.g., whenresponse.statusTextis undefined in some edge cases).Changes
nameis a string before calling.replace()ingetError()Test
This is a defensive fix - the error was encountered in production when certain HTTP responses had undefined statusText.
Co-Authored-By: Claude Opus 4.5 [email protected]