feat: Add significant time change breadcrumb#6112
Merged
philipphofmann merged 7 commits intomainfrom Sep 10, 2025
Merged
Conversation
When iOS posts a UIApplicationSignificantTimeChangeNotification the Cocoa SDK nows adds a breadcrumb. Fixes GH-5161
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6112 +/- ##
=============================================
- Coverage 86.578% 86.490% -0.089%
=============================================
Files 433 432 -1
Lines 36941 36826 -115
Branches 17418 17328 -90
=============================================
- Hits 31983 31851 -132
- Misses 4914 4932 +18
+ Partials 44 43 -1
... and 22 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
6 tasks
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6502818 | 1229.08 ms | 1245.46 ms | 16.37 ms |
| 75b23cd | 1227.10 ms | 1253.61 ms | 26.51 ms |
| efa740d | 1220.71 ms | 1246.20 ms | 25.50 ms |
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms |
| fc05805 | 1220.63 ms | 1252.16 ms | 31.54 ms |
| 5846fc5 | 1223.25 ms | 1248.79 ms | 25.54 ms |
| 397b9c9 | 1230.23 ms | 1249.29 ms | 19.06 ms |
| db9572a | 1223.13 ms | 1241.60 ms | 18.47 ms |
| 2e79f5f | 1220.53 ms | 1249.35 ms | 28.82 ms |
| 5cfc768 | 1220.74 ms | 1245.06 ms | 24.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6502818 | 23.75 KiB | 959.45 KiB | 935.70 KiB |
| 75b23cd | 23.75 KiB | 933.66 KiB | 909.92 KiB |
| efa740d | 23.75 KiB | 919.69 KiB | 895.95 KiB |
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB |
| fc05805 | 23.75 KiB | 908.02 KiB | 884.27 KiB |
| 5846fc5 | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| 397b9c9 | 23.75 KiB | 959.44 KiB | 935.70 KiB |
| db9572a | 23.75 KiB | 858.64 KiB | 834.89 KiB |
| 2e79f5f | 23.75 KiB | 928.87 KiB | 905.12 KiB |
| 5cfc768 | 23.75 KiB | 850.73 KiB | 826.98 KiB |
Previous results on branch: feat/significant-time-change-notification
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e067157 | 1213.98 ms | 1252.63 ms | 38.65 ms |
| b64543e | 1244.02 ms | 1247.17 ms | 3.15 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e067157 | 23.75 KiB | 963.16 KiB | 939.41 KiB |
| b64543e | 23.75 KiB | 963.15 KiB | 939.40 KiB |
philprime
approved these changes
Sep 9, 2025
Member
philprime
left a comment
There was a problem hiding this comment.
LGTM, left minor priority comments
Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Philip Niedertscheider <phil.niedertscheider@sentry.io>
…eadcrumbsTest.swift Co-authored-by: Philip Niedertscheider <phil.niedertscheider@sentry.io>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.5.0 to 5.5.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@fdcc847...5a10915) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: 5.5.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
When iOS posts a UIApplicationSignificantTimeChangeNotification, the Cocoa SDK now adds a breadcrumb.
Docs PR getsentry/sentry-docs#14848.
💡 Motivation and Context
Fixes GH-5161 and unblocks .NET
💚 How did you test it?
Unit test and manually change the time on an actual device.
https://sentry-sdks.sentry.io/issues/6605337140/events/87c3cc007f8f4bd4b0cc4caaeea17eed/?project=5428557

📝 Checklist
You have to check all boxes before merging:
sendDefaultPIIis enabled.