feat: debug images for Portable PDB

[vaind]

This adds the new event properties defined in RFC 0013, namely InstructionAddress / FunctionId + Relative Indexing, and a list of pe_dotnet DebugImages.

• replaces the original PR feat: Capture Debug Images and StackFrame fields for Portable PDB symbolication #1785 with a different approach to avoid adding new interface methods to ISentryStackTraceFactory
• closes Line number for .NET stack traces with server-side PDB support #1740

TODOs & followups

• make sure we know how this affects existing issues grouping - seems to be creating new issues if users upload symbols meaning all ignored issues would be resurrected too.
• add changelog, depending on the previous item
• docs, if needed
• Android doesn't contain assemblies as DLLs
• generate PDBs for Sentry libraries (see the asp.net (or Android) event below) (see sentry-cli uploading PDBs fails when symbols embedded #2073)
• unit test MergeDebugImagesInto()
• unit test for stack traces to contain (correct) debug images
• maybe device tests that debug images are actually sent? Locally, this seems covered because we're testing it through the verifier.

Event examples

Notice the presence of the "Images loaded" section and the line numbers in (full) stack traces. All apps were built with the following commands before executing:

cd samples/<sample-name>
git clean -ffxd . # after a branch switch
dotnet build --configuration Release 
sentry-cli upload-dif --project=sentry-dotnet --org=sentry-sdks --wait bin/Release/
rm -vf ./**/*.pdb # Remove-Item ./* -Recurse -Include "*.pdb"

• Basic CLI
  • main branch
  • this PR
• Complex CLI - longer stack trace (click "Full stack trace")
  • main branch
  • this PR - this also successfully fetched System.Private.CoreLib.dll from a MS symbol server
• Android MAUI
  • main branch
  • this PR
• ASP.NET core MVC - multiple exceptions in a single event (also click "Full stack trace")
  • main branch
  • this PR
• MacCatalyst
  • main branch
  • this PR
• iOS
  • main branch
  • this PR
  • this PR, MAUI

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2c532be

[Swatinem]

Thanks @vaind for picking this up ❤️

Serverside everything should be ready, you should be able to upload portable pdb files via sentry-cli, and serverside symbolication should pick up the new event properties. Feel free to reach out to me anytime if you need help.

[bruno-garcia]

First pass. I'll come back to review those AssemblyReaders and other bits

[bruno-garcia]

Forgot to thank you for doing this. This is a huge step for Sentry's .NET support. 🙏

[Swatinem]

I haven’t reviewed the AssemblyReader in too much detail.
lgtm, though I would rather defer proper review to @bruno-garcia

[mattjohnsonpint]

Almost done here. Some failures to investigate. Will finish and merge soon. Overall looking pretty good. 🙂

[mattjohnsonpint]

There's an issue with Verify getting in the way here. Addressing that in #2092.

[mattjohnsonpint]

@vaind - I pushed some changes to address the items I saw, and merged this. Got caught on the unrelated Verify issue along the way, but that's fixed now too. The main changes were:

• Moved the Android assembly reader classes to their own folder/namespace under src/Sentry/Platforms/Android/AssemblyReader. That will keep them only being distributed with the Android target.
• Made a separate test project Sentry.Android.Tests that pulls in those files manually for the non-Android testing.
• Updated the LZ4 dependency also, so only the Android target depends on it at runtime.
• Made a separate app in test/AndroidTestApp that is used for the apk tests. That prevents some circular build issues (since it doesn't depend on Sentry) and it also builds faster anyway.

Everything else was minor refactoring and a few script changes. Overall things looked pretty good to me. Thanks for your hard work on this one!

I did see a few unused items in AndroidAssemblyStoreReader. I left them there, since the comment said the code was adapted from Xamarin sources. But if you think we don't need them then let me know (or send a new PR). They are:

• AssemblyStoreExplorer.Assemblies
• AssemblyStoreManifestReader.Entries
• AssemblyStoreManifestEntry.StoreId
• AssemblyStoreManifestEntry.IndexInStore
• AssemblyStoreHashEntry.Is32Bit
• AssemblyStoreAssembly.GetDebugData
• AssemblyStoreAssembly.GetAssemblyConfig

Thanks.