feat: Don't dedupe from inner exception#363
Merged
bruno-garcia merged 1 commit intomasterfrom Feb 16, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
+ Coverage 93.32% 93.33% +<.01%
==========================================
Files 117 117
Lines 2802 2806 +4
==========================================
+ Hits 2615 2619 +4
Misses 187 187
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds modes to de-duplication of events.
Removes the dedupe for inner exceptions.
The mains driver is EF Core that logs an exception like this:
And rethrows. When Sentry wants to log it, it's dropped by the dedupe.
The stack trace from the EF Core entry is useless to the app developer, oesn't lead to the code that started the query.
Deduping InnerExceptions can be opt-in again via: