Fix #2710 - Return macOS instead of 'Darwin' and return proper version#3956
Merged
Fix #2710 - Return macOS instead of 'Darwin' and return proper version#3956
Conversation
Collaborator
jamescrosswell
left a comment
There was a problem hiding this comment.
LGTM as soon as all the CI checks are green.
Thanks @aritchie !
jamescrosswell
approved these changes
Feb 12, 2025
bruno-garcia
approved these changes
Feb 12, 2025
Member
bruno-garcia
left a comment
There was a problem hiding this comment.
ideally would go on a major bump because technically breaks saved search and tag distribution based on that OS tag. But I'd say unlikely to be a real disruption and the value of the change is worth the risk.
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Dec 8, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2710
Enricher will now check if running in a mac environment (runtime as we don't target mac targetframework) and switch "Darin" to "macOS" as well as set the operating system version properly
NOTES: