fix: MSBuild target produces incorrect release name#4015
Merged
jamescrosswell merged 4 commits intogetsentry:mainfrom Mar 26, 2025
Merged
fix: MSBuild target produces incorrect release name#4015jamescrosswell merged 4 commits intogetsentry:mainfrom
jamescrosswell merged 4 commits intogetsentry:mainfrom
Conversation
Collaborator
|
Tested manually on MacOS and the new commands run by the transitive build still work fine: Thanks @huynhsontung ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4015 +/- ##
==========================================
+ Coverage 75.73% 76.77% +1.04%
==========================================
Files 357 397 +40
Lines 13466 14418 +952
Branches 2671 2896 +225
==========================================
+ Hits 10198 11069 +871
- Misses 2593 2635 +42
- Partials 675 714 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bruno-garcia
approved these changes
Mar 8, 2025
jamescrosswell
approved these changes
Mar 26, 2025
Collaborator
|
Thanks again @huynhsontung - apologies it took so long to merge this. It'll be included in the next point release. |
This was referenced Aug 18, 2025
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 6, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4005
Remove the single quotes in the Exec tasks within the MSBuild target to prevent them from being included in the release name. This is necessary because Exec tasks invoke the Command Prompt, which does not strip quotes from parameters.