Merged
Conversation
Without Directory.Build.props, nuget.config etc.
the integration test reads sentry version from there
Collaborator
Author
|
Background: As you might notice from the commit history, I started with trying to make the existing integration test fail but eventually gave up. Since I had a set of commands (#4296 (comment)) I was able to use to reproduce the error locally, I decided to try running those in the CI. First, directly in the workflow for Linux, then as a manual test script for all platforms, and finally, I turned it into a Pester test script. The second last commit shows what kind of failures the new integration test produces when the properties are not correctly evaluated: ubuntu-22.04 (linux-x64)https://github.com/getsentry/sentry-dotnet/actions/runs/15779751203/job/44482314804 windows-latest (win-x64)https://github.com/getsentry/sentry-dotnet/actions/runs/15779751203/job/44482314808 |
This was referenced Sep 8, 2025
This was referenced Sep 15, 2025
This was referenced Oct 2, 2025
This was referenced Oct 15, 2025
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced by #4275: the
_SentryIsNet8OrGreaterhelper property was not correctly evaluated when publishing AOT, and Sentry was used as a NuGet package.The newly introduced integration test creates a minimal AOT app out of the tree in the system temp directory, and tests both
PublishAotand alsoPublishContaineron Linux with Docker available.Fixes: #4296