Only register MauiSessionReplayMaskControlsOfTypeBinder when relevant#4445
Merged
jamescrosswell merged 19 commits intomainfrom Sep 3, 2025
Merged
Only register MauiSessionReplayMaskControlsOfTypeBinder when relevant#4445jamescrosswell merged 19 commits intomainfrom
jamescrosswell merged 19 commits intomainfrom
Conversation
Closed
jamescrosswell
commented
Aug 19, 2025
Collaborator
Author
|
@Flash0ver it's lucky I took another look at this on the back of our chat yesterday. I had things completely backwards. See updated description in this PR and updated code. It's maybe worth considering whether we want to offer the |
jamescrosswell
commented
Aug 22, 2025
Flash0ver
reviewed
Aug 22, 2025
| { | ||
| services.AddSingleton<IMauiElementEventBinder, MauiCustomSessionReplayMaskBinder>(); | ||
| } | ||
| #endif |
Member
There was a problem hiding this comment.
Is that untrue because
- the
BindablePropertydoes set the tags for native (""sentry-mask""and"sentry-unmask") already - where the
IMauiElementEventBindermust now do the same for all configuredMaskedControls/UnmaskedControls
?
(just clarifying if I'm understanding it)
This was referenced Sep 22, 2025
This was referenced Oct 1, 2025
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Nov 3, 2025
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jan 18, 2026
This was referenced Mar 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4439:
Summary
In applications with complex user interfaces consisting of hundreds of controls on any individual page, the overhead of adding and removing events hooks to all of the
VisualElement.Loadedevents can cause significant performance delays.We use this event hook to set the Masking behaviour for visual controls of or descending from a particular type (controlled via
NativeSentryReplayOptions.MaskControlsOfType<T>()andNativeSentryReplayOptions.UnmaskControlsOfType<T>()).This PR:
MaskControlsOfTypeorUnmaskControlsOfTypeoptions are used