fix: protect UnsampledTransaction against double-Dispose#4722
fix: protect UnsampledTransaction against double-Dispose#4722jamescrosswell merged 7 commits intoversion6from
UnsampledTransaction against double-Dispose#4722Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version6 #4722 +/- ##
===========================================
Coverage ? 73.26%
===========================================
Files ? 480
Lines ? 17433
Branches ? 3440
===========================================
Hits ? 12772
Misses ? 3815
Partials ? 846 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alexsohn1126
left a comment
There was a problem hiding this comment.
None of the tests that are added seems to look for the double-dispose use case that this PR is trying to prevent.
Maybe something like DoubleDispose_DoseNothing?
The test |
Fixes #4719
Follow-up to #4717.
Merge into
version6branch after merging #4717.Mimicking implementation of
Sentry.TransactionTracer.#skip-changelog