Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR will not appear in the changelog. 🤖 This preview updates automatically when you update the PR. |
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
bitsandfoxes
force-pushed
the
feat/scope-sync-attachments
branch
from
c6cc055 to
2f13317
Compare
Co-authored-by: sentry-warden[bot] <258096371+sentry-warden[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5038 +/- ##
==========================================
+ Coverage 73.94% 74.02% +0.08%
==========================================
Files 497 499 +2
Lines 17974 18065 +91
Branches 3517 3518 +1
==========================================
+ Hits 13291 13373 +82
- Misses 3825 3834 +9
Partials 858 858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| { | ||
| other.AddAttachment(attachment); | ||
| // Set the attachment directly to avoid triggering a scope sync | ||
| other._attachments.Add(attachment); |
There was a problem hiding this comment.
The pushing and popping the scope does not get propagated to the native layer. So syncing the same attachments again doesn't make sense.
1 participant
Relates to getsentry/sentry-native#1584 and getsentry/sentry-java#5211
Allows syncing attachments to native layers. This will require a followup to implement the actual Android/iOS scope sync but unblocks Unity SDK.
#skip-changelog