Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #974 +/- ##
==========================================
+ Coverage 80.99% 81.10% +0.10%
==========================================
Files 183 183
Lines 5868 5868
Branches 1447 1447
==========================================
+ Hits 4753 4759 +6
+ Misses 697 692 -5
+ Partials 418 417 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
@bruno-garcia ran the CI 3 times, seems like this set of tests runs consistently. There are 3 there are still flaky though, skipped them. |
bruno-garcia
approved these changes
May 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#skip-changelog
Closes #608
Closes #743
Closes #935
Closes #936
Closes #607
Closes #608
Closes #639
Closes #653
Closes #878
Still flaky:
Sentry.NLog.Tests.SentryTargetTests.Log_SourceContextMatchesSentry_NoScopeConfigured: NSubstitute.Exceptions.ReceivedCallsException : Expected to receive no calls matchingSentry.NLog.Tests.SentryTargetTests.Log_SourceContextContainsSentry_NoScopeConfigured: NSubstitute.Exceptions.ReceivedCallsException : Expected to receive no calls matching: