feat(transport): handle HTTP 413 responses for oversized envelopes#982
Merged
feat(transport): handle HTTP 413 responses for oversized envelopes#982
Conversation
- Add :envelope_too_large reason to ClientError with specific error message - Handle HTTP 413 in Transport without retrying (similar to 429) - Record client report with :send_error reason per SDK spec - Log warning about envelope being rejected due to size limits This implements the SDK specification for handling HTTP 413 Content Too Large responses from Relay. Previously, oversized envelopes received HTTP 400 Bad Request, but Relay now returns HTTP 413 to allow SDKs to distinguish size-related rejections from other errors. Closes #978 Signed-off-by: Peter Solnica <peter@solnica.online>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the SDK specification for handling HTTP 413 Content Too Large responses from Relay. Previously, oversized envelopes received HTTP 400 Bad Request, but Relay now returns HTTP 413 to allow SDKs to distinguish size-related rejections from other errors.
:envelope_too_largereason toClientErrorwith specific error messageTransportwithout retrying (similar to 429):send_errorreason per SDK specCloses #978