feat: Expose exclude and include options for ESM loader#12910
Merged
AbhiPrasad merged 1 commit intodevelopfrom Jul 15, 2024
Merged
feat: Expose exclude and include options for ESM loader#12910AbhiPrasad merged 1 commit intodevelopfrom
exclude and include options for ESM loader#12910AbhiPrasad merged 1 commit intodevelopfrom
Conversation
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jul 15, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Interesting! Didn't know that iitm has this possibility.
LGTM - as a follow-up, I think we should also add this to our docs. Mentioning it in the ESM guide is probably a good place but it's fairly exposed. Feel free to add it wherever you think it makes sense!
Collaborator
Author
Ah good point, I should have mentioned that I added this feature here: |
AbhiPrasad
approved these changes
Jul 15, 2024
This was referenced Aug 7, 2024
This was referenced Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12878
I added this feature to
import-in-the-middlewhich was released in v1.9.0:includeorexcludelist viamodule.register()nodejs/import-in-the-middle#124This PR changes the hook from
@opentelemetry/instrumentation/hook.mjstoimport-in-the-middle/hook.mjsas it was only pasing though anyway and the otel hook doesn't pass theinitializeexport.