feat(browser): allow sentry in safari extension background page#13209
Merged
Lms24 merged 3 commits intogetsentry:developfrom Aug 13, 2024
Merged
Conversation
Lms24
reviewed
Aug 8, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Hey @undead-voron thanks for opening this PR! I think this sounds reasonable given we've done this before and it only applies to extensions running in dedicated pages, not within a host page. Would you mind adding a test for it? A simple one here is fine for me:
sentry-javascript/packages/browser/test/sdk.test.ts
Lines 202 to 223 in 0ca8821
Member
|
heads-up: I'm only assigning myself to track internally that I'm reviewing it. I'm not gonna take over for the test, please continue :) |
Contributor
Author
|
Hi @Lms24 |
Lms24
added a commit
that referenced
this pull request
Aug 13, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13209 --- Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
safari-web-extension:to the list of allowed extension protocols. This chage should allow sentry/browser to work in safari browser extensions.