feat(astro): Add bundleSizeOptimizations vite options to integration
#13250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
size-limit report 📦
|
Lms24
approved these changes
Aug 6, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
thanks for splitting up the PRs! LGTM!
mydea
reviewed
Aug 6, 2024
| assets: uploadOptions.assets ?? [getSourcemapsAssetsGlob(config)], | ||
| }, | ||
| bundleSizeOptimizations: { | ||
| excludePerformanceMonitoring: options.bundleSizeOptimizations?.excludeTracing || false, |
Member
There was a problem hiding this comment.
m: What about passing all the bundle size optimizations through (or more specifically, defining all of them)?
Lms24
approved these changes
Aug 6, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for updating! LGTM!
(let's make sure to update the PR title to reflect that we now include all options)
Lms24
requested changes
Aug 6, 2024
| }, | ||
| debug: options.debug ?? false, | ||
| }), | ||
| bundleSizeOptimizations: options.bundleSizeOptimizations, |
Member
There was a problem hiding this comment.
h: sorry almost missed this but the vite plugin doesn't yet support excludeTracing, right?
I think we need to remap this key specifically to excludePerformanceMonitoring
s1gr1d
changed the title
bundleSizeOptimizations.excludeTracingbundleSizeOptimizations vite options to integration
Lms24
approved these changes
Aug 6, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for adjusting! Now we can 
This was referenced Aug 30, 2024
This was referenced Aug 30, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundler-plugins still refer to the option as
excludePerformanceMonitoring(here), but this is going to be renamed toexcludeTracing, so I already used the new naming as discussed with @Lms24 and @mydea.part of #13013