feat(sveltekit): Add bundle size optimizations to plugin options#13318
Merged
feat(sveltekit): Add bundle size optimizations to plugin options#13318
Conversation
Member
|
hmm, now that I look at this - maybe it would make more sense to add the We can still merge this as-is and then remove the alias once we published this upstream & bumped this in here, though! |
Member
Author
|
This was already done in this PR and and I just saw it is also released: https://github.com/getsentry/sentry-javascript-bundler-plugins/releases/tag/2.22.0 I will update the version :) |
Lms24
approved these changes
Aug 12, 2024
Member
Lms24
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the option merging logic!
s1gr1d
added a commit
that referenced
this pull request
Aug 13, 2024
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it possible to add bundle size optimizations along with source maps options to the SvelteKit plugin options like this:
A bit of refactoring was done as well in the PR:
./typesgenerateVitePluginOptionswhich merges all SvelteKit plugin options correctly to create the Vite Plugin options (+ tests for this function)part of #13011