feat(browser): Add onRequestSpanStart hook to browser tracing integration#15979
Merged
feat(browser): Add onRequestSpanStart hook to browser tracing integration#15979
onRequestSpanStart hook to browser tracing integration#15979Conversation
Contributor
size-limit report 📦
|
mydea
reviewed
Apr 4, 2025
mydea
reviewed
Apr 4, 2025
Lms24
reviewed
Apr 4, 2025
Member
Lms24
left a comment
There was a problem hiding this comment.
The hook sounds reasonable to me! Can we add an integration test for it?
Contributor
Author
yes tests are missing yet - hence pr in draft mode |
Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a hook to the browser tracing integration that allows to hook into the creation of request spans (fetch & xhr) and set attributes based on headers (can be extended with additional info in the future).
Primarily I was gonna use this to set an attribute/op on prefetch client requests in Next.js to show them as
http.client.prefetch.