fix(nextjs): Handle async params in url extraction#17162
Merged
Conversation
andreiborza
reviewed
Jul 25, 2025
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Could we test this somehow?
Member
Author
|
Tests for this are already in place, or do you mean the extract function? |
Member
no, I mean can we assert on this not causing warnings/errors in the tests? I think (prior to this fix) they were logged out to stdout right? |
andreiborza
approved these changes
Jul 25, 2025
Member
Author
ah yeah I can see if there's a way to test that, I only tested it in a sample app |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/nextjs-15/tests/async-params.test.ts
Outdated
Show resolved
Hide resolved
andreiborza
approved these changes
Jul 25, 2025
Member
andreiborza
left a comment
andreiborza
left a comment
There was a problem hiding this comment.
Thanks for adding the test!
chargome
added a commit
that referenced
this pull request
Jul 25, 2025
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes https://linear.app/getsentry/issue/JS-535/error-route-used-searchparams-sentry-skip-normalization-searchparams
closes #16542
Unfortunately we can't resolve the params promise within the template as making this async leads to some nasty RSC errors which we want to stay away from.