fix(node): Assign default export of openai to the instrumented fn#17320
Merged
RulaKhaled merged 2 commits intodevelopfrom Aug 5, 2025
Merged
fix(node): Assign default export of openai to the instrumented fn#17320RulaKhaled merged 2 commits intodevelopfrom
openai to the instrumented fn#17320RulaKhaled merged 2 commits intodevelopfrom
Conversation
RulaKhaled
changed the title
openai to the instrumented fnopenai to the instrumented fn
Contributor
size-limit report 📦
|
mydea
approved these changes
Aug 5, 2025
Member
mydea
left a comment
mydea
left a comment
There was a problem hiding this comment.
can we maybe also add a test covering this? (could also be in a follow up)
mydea
reviewed
Aug 5, 2025
| try { | ||
| exports.default = WrappedOpenAI; | ||
| } catch (error) { | ||
| Object.defineProperty(exports, 'default', { |
Member
There was a problem hiding this comment.
could we add a comment here explaining what we do here and why? When would this fail, and would the catch block work then? Can/should we just always do the catch block here?)
andreiborza
pushed a commit
that referenced
this pull request
Aug 8, 2025
#17320) Both of: - import OpenAI from `openai` - import { OpenAI } from`openai` Should point to the instrumented wrapper function.
andreiborza
added a commit
that referenced
this pull request
Aug 8, 2025
Both of:
- import OpenAI from `openai`
- import { OpenAI } from`openai`
Should point to the instrumented wrapper function.
Backport of #17320.
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of:
openaiopenaiShould point to the instrumented wrapper function.