feat(bun): Export skipOpenTelemetrySetup option#17349
Merged
Conversation
3 tasks
s1gr1d
approved these changes
Aug 7, 2025
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
You already wrote in the description that this option will be passed to the underlying Node integration. Will this also disable spans in this case? As this is connected with the spans option in the Http integration:
sentry-javascript/packages/node/src/integrations/http/index.ts
Lines 29 to 36 in 47f85b9
Member
Author
|
yes, that's correct. Setting |
This was referenced Sep 29, 2025
This was referenced Oct 7, 2025
This was referenced Oct 15, 2025
This was referenced Dec 9, 2025
JPeer264
added a commit
that referenced
this pull request
Dec 10, 2025
(closes #18419) (closes [JS-1261](https://linear.app/getsentry/issue/JS-1261/add-support-for-spotlight-in-sentrybun)) It seems that for Bun we are already using the init function of `@sentry/node`, so all the options are passed do satisfy the `NodeOptions`. This is now re-exporting `spotlight` as an option. (related: #17349)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As raised in #16969, the Bun SDK doesn't currently export
skipOpenTelemetrySetupin the SDK init options type, altghough the option can be correctly passed to the underlyingNodeClient. This PR exports the option now.#16969 (comment)