feat(nuxt): Bump @sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1#18349
Merged
feat(nuxt): Bump @sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1#18349
@sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1#18349Conversation
Lms24
changed the title
@sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1@sentry/vite-plugin and @sentry/rollup-plugin to 4.6.1
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
approved these changes
Nov 28, 2025
Lms24
force-pushed
the
lms/deps-nuxt-plugins
branch
from
b5f6880 to
f3cf791
Compare
s1gr1d
approved these changes
Dec 4, 2025
Lms24
force-pushed
the
lms/deps-nuxt-plugins
branch
from
f3cf791 to
2c39c62
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| project, | ||
| // same handling as in bundler plugins: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/05084f214c763a05137d863ff5a05ef38254f68d/packages/bundler-plugin-core/src/build-plugin-manager.ts#L102-L103 | ||
| project: Array.isArray(project) ? project[0] : project, | ||
| ...sentryConfig.unstable_sentryVitePluginOptions, |
There was a problem hiding this comment.
Bug: Spread overwrites normalized project value
The SentryCli constructor carefully normalizes project from array to string on line 69, but then immediately spreads ...sentryConfig.unstable_sentryVitePluginOptions on line 70. Since unstable_sentryVitePluginOptions may contain its own project property (potentially an array), this spread overwrites the normalized value, defeating the purpose of the array-to-string conversion. The spread should come before the project property, not after.
| project, | ||
| // same handling as in bundler plugins: https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/05084f214c763a05137d863ff5a05ef38254f68d/packages/bundler-plugin-core/src/build-plugin-manager.ts#L102-L103 | ||
| project: Array.isArray(project) ? project[0] : project, | ||
| ...sentryConfig.unstable_sentryVitePluginOptions, |
There was a problem hiding this comment.
Bug: Spread overwrites normalized project value
The SentryCli constructor carefully normalizes project from array to string on line 69, but then immediately spreads ...sentryConfig.unstable_sentryVitePluginOptions on line 70. Since unstable_sentryVitePluginOptions may contain its own project property (potentially an array), this spread overwrites the normalized value, defeating the purpose of the array-to-string conversion. The spread should come before the project property, not after.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#18270 bumps just the rollup plugin but we should bump both simultaneously.