feat(billing): added account protos(REVENG-79)#254
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
| message AccountStatus { | ||
| // The organization this status belongs to. Each org has one AccountStatus. | ||
| uint64 organization_id = 1; | ||
| // Legacy soft cap flag. When true, no category is rate-limited regardless of usage. |
There was a problem hiding this comment.
Do we still need a legacy flag on billing platform?
There was a problem hiding this comment.
This is just referencing the fact that softcaps can now be enabled per category, previously the 'legacy' version applied to the whole subscription and just meant we didn't rate limit them at all. We still use this for use cases like giving an unlimited trial to enterprise orgs that are on a subscription trial etc.
There was a problem hiding this comment.
I think that will end up being managed by the new trials service and not by this flag now
| // Current account status (active, closed, past-due). | ||
| Status status = 3; | ||
| // Whether the account is suspended by an admin (e.g., for fraud). | ||
| bool is_suspended = 4; |
There was a problem hiding this comment.
Is this redundant with the status enum?
There was a problem hiding this comment.
we currently store this in the existing codebase separately, but i'm fine with merging them tbh
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c1e8673. Configure here.
2 participants
https://linear.app/getsentry/issue/REVENG-79/create-accountstatus-proto
This PR adds protos for an account's status, which represent org-wide information not contained on the contract such as org status, soft cap eligibility etc.