feat(flags): Remove graduated dashboards-mep feature flag#108809
feat(flags): Remove graduated dashboards-mep feature flag#108809
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
| ) -> Mapping[str, bool | None]: | ||
| feature_names = [ | ||
| "organizations:performance-use-metrics", | ||
| "organizations:dashboards-mep", |
There was a problem hiding this comment.
Dead get_features method never called after removal
Low Severity
The get_features method in OrganizationEventsTimeseriesEndpoint is now dead code. The only call site (batch_features = self.get_features(...)) was removed in this PR, but the method definition was left behind. No parent class or subclass calls this method either.
The previous commit simplified use_metrics in organization_events_stats.py and organization_events_timeseries.py but missed 5 other files that had the same `or True` dead code pattern. This removes the dead feature flag checks and unused batch_features variables where applicable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) -> Mapping[str, bool | None]: | ||
| feature_names = [ | ||
| "organizations:performance-use-metrics", | ||
| "organizations:dashboards-mep", |
There was a problem hiding this comment.
Dead get_features method never called after cleanup
Low Severity
The get_features method in OrganizationEventsTimeseriesEndpoint is now dead code — its only caller (batch_features = self.get_features(...)) was removed as part of this PR, but the method definition was kept and even modified (to remove dashboards-mep from its feature list). The same applies to get_features in DataExportEndpoint. Both methods still fetch feature flags via features.batch_has but are never invoked.
Additional Locations (1)
| "organizations:mep-rollout-flag", | ||
| "organizations:dynamic-sampling", | ||
| "organizations:performance-use-metrics", | ||
| "organizations:dashboards-mep", |
There was a problem hiding this comment.
Dead get_metrics_features method never called after cleanup
Low Severity
The get_metrics_features methods in DashboardWidgetQuerySerializer and DiscoverSavedQuerySerializer are now dead code. Their only callers in the respective validate methods were removed when use_metrics was hardcoded to True, but the method definitions remain (and were even modified to remove dashboards-mep from their feature lists). No other code calls these methods.
Additional Locations (1)
1 participant
Summary
Removes the
organizations:dashboards-mepfeature flag that has been enabled at 100% via flagpole with no conditions.This flag has been fully rolled out and its behavior is now the default.
Test plan
🤖 Generated with Claude Code