Skip to content

fix(dashboards): Stop widget header action clicks from bubbling #116096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skaasten merged 2 commits into from
May 25, 2026
Merged

fix(dashboards): Stop widget header action clicks from bubbling #116096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad5d21
fix(dashboards): Hide full-screen view for widgets with a slideout dr…
skaasten May 22, 2026
34d99d0
fix(dashboards): Stop widget header action clicks from bubbling
skaasten May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions static/app/views/dashboards/widgetCard/widgetFrame.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ export function WidgetFrame(props: WidgetFrameProps) {
<LinkButton
size="xs"
disabled={props.actionsDisabled}
onClick={actions[0]!.onAction}
onClick={e => {
e.stopPropagation();
actions[0]!.onAction?.();
}}
to={actions[0]!.to}
>
{actions[0]!.label}
Expand All @@ -117,7 +120,10 @@ export function WidgetFrame(props: WidgetFrameProps) {
<Button
size="xs"
disabled={props.actionsDisabled}
onClick={actions[0]!.onAction}
onClick={e => {
e.stopPropagation();
actions[0]!.onAction?.();
}}
>
{actions[0]!.label}
</Button>
Expand Down Expand Up @@ -148,7 +154,8 @@ export function WidgetFrame(props: WidgetFrameProps) {
aria-label={t('Copy Widget URL')}
variant="transparent"
icon={<IconCopy />}
onClick={() => {
onClick={e => {
e.stopPropagation();
props.onCopyUrlClick?.();
}}
/>
Expand All @@ -161,7 +168,8 @@ export function WidgetFrame(props: WidgetFrameProps) {
aria-label={t('Open Full-Screen View')}
variant="transparent"
icon={<IconExpand />}
onClick={() => {
onClick={e => {
e.stopPropagation();
props.onFullScreenViewClick?.();
}}
/>
Expand Down
Loading