Skip to content

Add total allocated bytes to MemoryInfoContext#93013

Merged
leeandher merged 3 commits intogetsentry:masterfrom
KnapSac:fix-allocated-bytes-label
Jun 23, 2025
Merged

Add total allocated bytes to MemoryInfoContext#93013
leeandher merged 3 commits intogetsentry:masterfrom
KnapSac:fix-allocated-bytes-label

Conversation

@KnapSac
Copy link
Copy Markdown
Contributor

@KnapSac KnapSac commented Jun 6, 2025

Adds the total_allocated_bytes property added in getsentry/sentry-dotnet#4243 to the static types.

cc @jamescrosswell

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@KnapSac KnapSac requested a review from a team as a code owner June 6, 2025 12:43
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 6, 2025
@KnapSac
Copy link
Copy Markdown
Contributor Author

KnapSac commented Jun 21, 2025

Is there anything I can do to move this PR forward? Because the UI doesn't know about the total_allocated_bytes value sent by new versions of the .NET SDK it gets rendered as a number, which isn't very readable.

@jamescrosswell
Copy link
Copy Markdown

@evanpurkhiser would you know who @KnapSac should be working with on this?

There's a complimentary change for this PR in the sentry-dotnet repo which has already been merged/shipped.

@leeandher leeandher added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 23, 2025
@leeandher leeandher merged commit f2ba12b into getsentry:master Jun 23, 2025
42 of 43 checks passed
@leeandher
Copy link
Copy Markdown
Member

@KnapSac thank you so much for your contribution and follow up! it's appreciated and should be visible in the UI within a few hours 🙏

@KnapSac KnapSac deleted the fix-allocated-bytes-label branch June 23, 2025 15:13
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants