ref(feedback): do not validate userreport email#94664
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
4 tasks
michellewzhang
approved these changes
Jun 30, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #94664 +/- ##
=======================================
Coverage 87.92% 87.92%
=======================================
Files 10425 10425
Lines 603129 603117 -12
Branches 23470 23470
=======================================
- Hits 530274 530267 -7
+ Misses 72349 72344 -5
Partials 506 506 |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jul 14, 2025
Feedback v2, Relay, and issues does not validate the email format. We're deciding to leave validation up to SDK devs, it's not worth dropping the whole feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feedback v2, Relay, and issues does not validate the email format. We're deciding to leave validation up to SDK devs, it's not worth dropping the whole feedback