fix(ui): add validation guards to WebVitalsDetail to prevent crashes#1243
Merged
Conversation
Add the same validation logic used in the list view to the detail view: - Filter for events with measurements and op === 'pageload' - Verify score.total exists after normalization - Prevents crashes when navigating directly to invalid event URLs
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Replace multiple array method passes (filter -> map -> filter -> forEach) with a single for loop that combines all validation and normalization logic. This improves performance and readability while maintaining the same functionality.
This was referenced Jan 8, 2026
This was referenced Jan 12, 2026
This was referenced Jan 12, 2026
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
WebVitalsDetailcomponent crashes when navigating directly to a URL for an event that is not a valid pageload event with web vitals measurements.Root Cause
The list view filters events with three conditions:
event.measurementsexistsevent?.contexts?.trace?.op === "pageload"event.measurements["score.total"] != null(after normalization)The detail view only filtered by
event_id, then accessedmeasurements["score.fcp"].valuewithout null checks, causing a TypeError.Solution
Add the same validation logic to
WebVitalsDetail.tsxas exists inindex.tsx:measurementsANDop === "pageload"in addition toevent_idscore.totalexists after normalization