fix(deps): cap esbuild override to <0.28.0 to avoid regression#1301
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
esbuild 0.28.0 has a known regression (esbuild#4436) where it incorrectly errors on destructuring syntax for modern browser targets (chrome87, es2020, etc.) that natively support it. This broke the website build via @astrojs/react's client.js. Cap the override at <0.28.0 so vite@6.4.2 and tsx resolve to 0.27.4.
BYK
force-pushed
the
fix/cap-esbuild-override
branch
from
b904555 to
2ca6dc7
Compare
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 1348 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 76.31% 76.31% —%
==========================================
Files 47 47 —
Lines 5690 5690 —
Branches 611 614 +3
==========================================
+ Hits 4342 4342 —
- Misses 1348 1348 —
- Partials 5 5 —Generated by Codecov Action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuildpnpm override from>=0.25.0to>=0.25.0 <0.28.0to work around a known esbuild 0.28.0 regression (esbuild#4436)chrome87,es2020, etc.) that natively support it, breaking the@spotlightjs/websitebuild via@astrojs/react'sdist/client.jsrelease/4.11.4branch (build run)