test(e2e): Add E2E Astro tests#238
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
=======================================
Coverage 32.85% 32.85%
=======================================
Files 44 44
Lines 2030 2030
Branches 71 71
=======================================
Hits 667 667
Misses 1363 1363 ☔ View full report in Codecov by Sentry. |
BYK
added a commit
that referenced
this pull request
May 14, 2026
#1299) ## Summary Resolves 20 of 22 open Dependabot security alerts by updating direct dependencies and adding/updating pnpm overrides. The remaining 2 vite alerts (#234, #237) affecting vite 5.x in spotlight have been dismissed as tolerable risk (dev-only dependency). ## Changes ### Direct dependency updates - **hono** 4.12.14 → 4.12.18 — fixes 5 alerts (#252, #253, #256, #257, #258) - **@hono/node-server** 1.19.10 → 1.19.14 — fixes #238 ### pnpm override updates/additions - **vite** `>=6.0.0 <6.3.6` → `>=6.0.0 <6.4.2` with `~6.4.2` target — fixes #234 for vite 6.x - **vite** added `>=7.0.0 <7.3.2` → `>=7.3.2` override — covers future vite 7.x usage - **lodash** `>=4.17.23` → `>=4.18.0` — fixes #235, #236 - **defu** added `>=6.1.5` — fixes #233 - **fast-uri** added `>=3.1.2` — fixes #254, #255 - **ip-address** added `>=10.1.1` — fixes #251 ### Auto-resolving alerts (via transitive updates) - **@xmldom/xmldom** (#247–250) — already at 0.9.9, above patched 0.8.13 - **astro** (#245, #246, #259, #260) — updated transitively; alerts will auto-close ### Dismissed alerts - **#234** (vite WebSocket file read) — vite 5.4.21 not in vulnerable range `>= 6.0.0` - **#237** (vite path traversal `.map`) — dev-only risk; requires `--host` flag ## Verification - `pnpm run build --filter @spotlightjs/spotlight` — passed - `pnpm run test --filter @spotlightjs/spotlight` — 186/186 tests passed - Website build failure is pre-existing on main (unrelated esbuild/astro compat issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds E2E tests to our monorepo based on Playwright.
More Specifically, this PR
In the future, we can add more test apps for different frameworks.
I'm also gonna open a follow up PR to run these tests in CI