Skip to content

feat(profiling): Annotate flamegraph with profile data#501

Merged
Zylphrex merged 6 commits into
mainfrom
txiao/feat/annotate-flamegraph-with-profile-data
Aug 8, 2024
Merged

feat(profiling): Annotate flamegraph with profile data#501
Zylphrex merged 6 commits into
mainfrom
txiao/feat/annotate-flamegraph-with-profile-data

Conversation

@Zylphrex

@Zylphrex Zylphrex commented Aug 8, 2024

Copy link
Copy Markdown
Member

This annotates the flamegraph with metadata that allows us to link to a profile regardless if it's a transaction based profile or continuous profile.

This annotates the flamegraph with metadata that allows us to link to a profile
regardless if it's a transaction based profile or continous profile.
@Zylphrex Zylphrex requested a review from a team as a code owner August 8, 2024 00:21
Comment thread internal/flamegraph/flamegraph.go Outdated
@Zylphrex Zylphrex requested a review from viglia August 8, 2024 14:05

@viglia viglia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zylphrex Zylphrex merged commit 0d807f7 into main Aug 8, 2024
@Zylphrex Zylphrex deleted the txiao/feat/annotate-flamegraph-with-profile-data branch August 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants