Fix crash on command buffer drop#3726
Merged
Merged
Conversation
Wrong object was passed for `data` to `command_buffer_drop`
emilk
reviewed
Apr 24, 2023
emilk
reviewed
Apr 24, 2023
Member
Author
|
@emilk I agree with the two comments, but I intentionally sticked with the pattern of the other drop implementations in this file to make it less confusing. If there is no data object but an id we are in an invalid state and should not continue either, so we need to handle this error in some way. |
de497ae to
df51aa4
Compare
1 task
Wumpf
added a commit
to rerun-io/wgpu
that referenced
this pull request
May 14, 2023
cwfitzgerald
pushed a commit
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
cargo clippy.RUSTFLAGS=--cfg=web_sys_unstable_apis cargo clippy --target wasm32-unknown-unknownif applicable.Connections
Fixes #3724
Description
Oversight in: #3657
Passed the wrong object was passed for
datatocommand_buffer_drop, causing type conversion assertion to fail at runtime 😱Testing
Add minimal repro
to hello triangle. Before:
thread 'main' panicked at 'assertion failed: data.is::<T>()', wgpu/src/context.rs:1045:5