chores: set CMAKE_RUNTIME_OUTPUT_DIRECTORY for non standalone build#1394
Merged
ggerganov merged 1 commit intoDec 12, 2025
Merged
Conversation
Some backend depends on CMAKE_RUNTIME_OUTPUT_DIRECTORY to create temporary file like metal backened. Missing CMAKE_RUNTIME_OUTPUT_DIRECTORY will cause some cmake error like permission denied (try to copy file to root). This PR wants to setup a default path for CMAKE_RUNTIME_OUTPUT_DIRECTORY when it does not exist.
Contributor
|
Ran into this as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some backend depends on
CMAKE_RUNTIME_OUTPUT_DIRECTORYto create temporary file like metal backened.Missing
CMAKE_RUNTIME_OUTPUT_DIRECTORYwill cause some cmake error like permission denied (try to copy file to root).This PR wants to setup a default path for
CMAKE_RUNTIME_OUTPUT_DIRECTORYwhen it does not exist.