Merged
Conversation
slaren
reviewed
May 4, 2025
Member
slaren
left a comment
slaren
left a comment
There was a problem hiding this comment.
I think it still needs to be removed from llama_context_params.
Member
Author
|
Removed the flag from |
ggerganov
added
the
breaking change
ggerganov
force-pushed
the
gg/context-remove-logits-all
branch
from
d4ddcac to
6107303
Compare
slaren
approved these changes
May 8, 2025
Nexesenex
added a commit
to Nexesenex/croco.cpp
that referenced
this pull request
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag has been deprecated for quite some time and in order to simplify the logic in
llama_contextit's better to remove it. To achieve the same functionality, setllama_batch::logitsaccordingly.libllamaAPI Changeslogits_allflagboolflags at the end of the struct