webui: apply webui_settings on first load#18223
Conversation
The webui_settings from /props were not applied on initial load when default_generation_settings.params was null Now syncs whenever serverProps is available, regardless of params, works for both single-model and router modes
|
@ServeurpersoCom this seems to be mostly working, but the below settings do not change regardless of what is set in the JSON file. I verified most of other ones do. systemMessage |
Absolutely! Not all the parameters are in the original PR -> #18028 Added 14 WebUI settings to 'SYNCABLE_PARAMETERS': Feel free to tell me what's missing (Here or new issue please, but systemMessage showSystemMessage added to my TODO); I'll check what it implies in terms of the code and add them. |
PS: Thank you for working on this awesome tool! |
It's true that we currently have two configuration options:
Also, the frontend no longer sends the default sampling parameters, but it will do so if overridden by the user. Currently, the JSON file is incomplete, and can have some issues, but it should only be used for pure-UI preferences outside of the API (like sampling), which the backend can already handle per-models! |
Yep, I am using both: ini for models and the JSON file for the web UI non-sampler defaults. I also set the sampler values to "" in the JSON file so that they are set to the default in the UI and then allow my model ini config to work. (I am watching #18226 and will test it when it's released.)
Yep, I saw that. It seems to work well. |
Oh right, I remember now! My PR added UI settings to SYNCABLE_PARAMETERS and added the webuiSettings code path. The sampling params were already in SYNCABLE_PARAMETERS, so now they can be set via --webui-config too! |
Cool! Is it easy enough for you to just look at the list in this file and implement any of the ones that are still missing (like e.g. showSystemMessage)? Let me know if you need more info or testing from me. |
Yes, all things considered, it's best to put everything in and let the user do what they want, especially if it doesn't pose a security problem (backend, more trusted -> frontend). |
You can try master + #18226 :) everything is customizable via --webui-config-file. The JSON parameters will be:
|
I am not equipped to test outside of releases. I will take it for a spin as soon as it makes it into a release. Thanks! |
* webui: apply webui_settings on first load The webui_settings from /props were not applied on initial load when default_generation_settings.params was null Now syncs whenever serverProps is available, regardless of params, works for both single-model and router modes * chore: update webui build output
* webui: apply webui_settings on first load The webui_settings from /props were not applied on initial load when default_generation_settings.params was null Now syncs whenever serverProps is available, regardless of params, works for both single-model and router modes * chore: update webui build output
Make sure to read the contributing guidelines before submitting a PR
The webui_settings from /props were not applied on initial load when default_generation_settings.params was null
Now syncs whenever serverProps is available, regardless of params, works for both single-model and router modes
Close #18185 (Follow-up #18028 #17940)