Conversation
seia-soto
reviewed
Apr 28, 2026
seia-soto
approved these changes
Apr 28, 2026
Member
seia-soto
left a comment
seia-soto
left a comment
There was a problem hiding this comment.
I'd keep the order of the envs as in the uBlock Origin wiki page instead for quicker cross-checking in the future. Otherwise, looks good.
seia-soto
reviewed
Apr 28, 2026
seia-soto
requested changes
Apr 28, 2026
seia-soto
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align preprocessor env flags so extension identifiers map correctly to MV2/MV3 behavior.
ext_ublocktotrueext_ubolfor MV3 only.Review comment: